-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typos in deployment.mdx #9877
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Josh-Cena
requested changes
Feb 22, 2024
website/docs/deployment.mdx
Outdated
|
||
At this point, you should have: | ||
|
||
- the source repo with the GitHub workflow set with the private SSH key as the GitHub Secret, and | ||
- your deployment repo set with the public SSH key in GitHub Deploy Keys. | ||
- your deployment repo is set with the public SSH key in GitHub Deploy Keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a part of the sentence "At this point, you should have..." so it should be a noun, not a sentence, like the previous bullet point.
⚡️ Lighthouse report for the deploy preview of this PR
|
Oreoxmt
commented
Feb 22, 2024
slorber
added
the
pr: documentation
This PR works on the website or other text documents in the repo.
label
Feb 22, 2024
Thanks |
This was referenced May 19, 2024
This was referenced May 26, 2024
This was referenced May 27, 2024
This was referenced Jun 27, 2024
This was referenced Jul 17, 2024
This was referenced Jul 21, 2024
This was referenced Jul 21, 2024
This was referenced Aug 4, 2024
This was referenced Aug 12, 2024
This was referenced Aug 21, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: documentation
This PR works on the website or other text documents in the repo.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs