Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos in deployment.mdx #9877

Merged
merged 2 commits into from
Feb 22, 2024
Merged

docs: fix typos in deployment.mdx #9877

merged 2 commits into from
Feb 22, 2024

Conversation

Oreoxmt
Copy link
Contributor

@Oreoxmt Oreoxmt commented Feb 22, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 22, 2024
Copy link

netlify bot commented Feb 22, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 8ebf13a
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65d6d91294df6e00081fcf49
😎 Deploy Preview https://deploy-preview-9877--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


At this point, you should have:

- the source repo with the GitHub workflow set with the private SSH key as the GitHub Secret, and
- your deployment repo set with the public SSH key in GitHub Deploy Keys.
- your deployment repo is set with the public SSH key in GitHub Deploy Keys.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a part of the sentence "At this point, you should have..." so it should be a noun, not a sentence, like the previous bullet point.

Copy link

github-actions bot commented Feb 22, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 59 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 87 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 62 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

website/docs/deployment.mdx Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt requested a review from Josh-Cena February 22, 2024 05:18
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 22, 2024
@slorber
Copy link
Collaborator

slorber commented Feb 22, 2024

Thanks

@slorber slorber merged commit 06dabc6 into facebook:main Feb 22, 2024
10 checks passed
@Oreoxmt Oreoxmt deleted the patch-1 branch February 23, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants