Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use official GitHub Action to deploy to GitHub Pages #9937

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

vlad-nestorov
Copy link
Contributor

@vlad-nestorov vlad-nestorov commented Mar 10, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Update Github Actions deployment instructions to use the more Github way of doing things, and remove dependency on third party actions.

Test Plan

See this repo for an example successful run of the new instructions: https://github.com/vlad-nestorov/vlad-nestorov.github.io/actions/runs/8224051582/workflow

Test links

https://deploy-preview-9937--docusaurus-2.netlify.app/docs/deployment#triggering-deployment-with-github-actions

Update Github Actions deployment instructions to use the more Github way of doing things, and remove dependency on third party actions. 

See this for an example successful run: https://github.com/vlad-nestorov/vlad-nestorov.github.io/actions/runs/8224051582/workflow
@facebook-github-bot
Copy link
Contributor

Hi @vlad-nestorov!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

netlify bot commented Mar 10, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 3aaaa6f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65fc468c8caac50008f0d9a9
😎 Deploy Preview https://deploy-preview-9937--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 10, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 53 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 54 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 69 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 62 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 69 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 10, 2024
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 15, 2024
@slorber slorber changed the title Use GitHub Action publish source docs: use official GitHub Action to deploy to GitHub Pages Mar 15, 2024
website/docs/deployment.mdx Outdated Show resolved Hide resolved
website/docs/deployment.mdx Outdated Show resolved Hide resolved
website/docs/deployment.mdx Show resolved Hide resolved
@slorber slorber merged commit 6f17d54 into facebook:main Mar 21, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants