Xcode10 build fix when using carthage

[Nonnus]

Thanks for proposing a pull request.

To help us review the request, please complete the following:

• sign contributor license agreement
• submit against our dev branch, not master.
• describe the change (for example, what happens before the change, and after the change)

This pr fixes compiling with latest xcode 10 using carthage by implementing the fixes described in facebookarchive/facebook-swift-sdk#246

[vitorhugomagalhaes]

Any update on this please ?

[Nonnus]

i created the pr, now was waiting for someone to review it...

[vitorhugomagalhaes]

I'll use your fork to move forward. Thanks

[Nonnus]

@vitorhugomagalhaes keep in mind i also had to patch Bolts (BoltsFramework/Bolts-ObjC#323)

in the end to be able to keep working on xcode 10 i ended up making 3 forks and just set my cartfile to point to github "hellofresh/Facebook-SDK-Swift", feel free to use it as well ;)

[vitorhugomagalhaes]

Great. Thanks for sharing.

[codytwinton]

@vitorhugomagalhaes @Nonnus - we had an issue with the latest iOS SDK release where PRs were accidentally reverted on release. I'm doing some internal work to resolve this issue and I don't want to merge this PR until I can verify that it won't be reverted.

#880 (comment)

[codytwinton]

This all looks great, but we had an issue with the latest iOS SDK release where PRs were accidentally reverted on release. I'm doing some internal work to resolve this issue and I don't want to merge this PR until I can verify that it won't be reverted.

[vitorhugomagalhaes]

Any update here ?

[codytwinton]

Thank you for this PR! I'll import these changes internally and get it shipped asap.

[facebook-github-bot]

codytwinton has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[Nonnus]

@codytwinton my pleasure, happy I could help ;)

[vitorhugomagalhaes]

@Nonnus Did you confirmed that the dynamic Bolts framework was being generated on your PR. The hello fresh clone seems to be missing that and then the app will not be able to load it at runtime as required by the other FBSDK frameworks which do rely on the dynamic version of Bolts.

[codytwinton]

Still waiting on the PR in Bolts to be merged.