-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix map fieldtype issue #33
base: main
Are you sure you want to change the base?
Conversation
@alanho please let me know if you have any comment / feedback, |
any feedback or plan for merge @alanho ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanho has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
+1. I applied the patch in my project and waiting for this PR to be merged |
+1. Patch worked for me. |
+1 Also worked for me |
+1 also worked for me! |
Invalid field type (map<string, unsigned int>) #21
API response is JSON format data, and it's already decoded in
APIResponse
class, sovalue
indeserialize
method always should be hash format (decoded JSON object / hash). Somehow If it receives string value from API server, still needs to be parsed.