Add argument to pass extra arguments to boost b2 build tool (#115) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds an environment variable to getdeps to provide `hg` info to avoid calling `hg` directly. When using `getdeps` inside a containerized environment (which we need to build Research Super Cluster tooling with the correct linker attributes), `getdeps` fails because of unregistered mercurial extensions in the `hgrc`. This allows `getdeps` to be useable in an environment where the mercurial extensions used in a project aren't installed/available. Differential Revision: D34732506 fbshipit-source-id: 8cd08d5c3f46abae868168682cf6e0a9017317bc
Summary: When using getdeps inside of a container, Python's urllib isn't able to download from dewey lfs (see this post for details https://fb.workplace.com/groups/systemd.and.friends/permalink/2747692278870647/). This allows for getdeps to use `libcurl` to fetch dependencies, which allows for a getdeps build to work inside the container environment. Differential Revision: D34696330 fbshipit-source-id: 5bdd78bb25a63540de6bda380ca3beb472c34c4d
Summary: X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 9747fef6310f34b9d33f57b3e552a1fb9c886d6e
|
This pull request was exported from Phabricator. Differential Revision: D34796774 |
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebookarchive/fbzmq
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebookarchive/bistro
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 Pull Request resolved: #115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 Pull Request resolved: #1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 Pull Request resolved: #488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 Pull Request resolved: #403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
heartpunk
pushed a commit
to heartpunk/watchman
that referenced
this pull request
Mar 20, 2022
) Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
shiyu-bytedance
pushed a commit
to shiyu-bytedance/velox-1
that referenced
this pull request
Aug 18, 2022
…incubator#28) Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/fboss#115
X-link: facebook/folly#1736
X-link: facebook/proxygen#403
X-link: facebook/fbthrift#488
This adds a way to pass arguments to the
b2build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable.so. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects.Reviewed By: mackorone
Differential Revision: D34796774