-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add github CI signal #58
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D63976936 |
ahornby
added a commit
to ahornby/fb303
that referenced
this pull request
Oct 7, 2024
Summary: add a github action so its visible if fb303 compiles externally sapling github CI wangle step wangle had a failure in github CI on fb303 and I wasn't sure if fb303 was itself building ok. Differential Revision: D63976936
ahornby
force-pushed
the
export-D63976936
branch
from
October 7, 2024 11:27
fd57419
to
8476b90
Compare
This pull request was exported from Phabricator. Differential Revision: D63976936 |
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. Differential Revision: D63976936
ahornby
force-pushed
the
export-D63976936
branch
from
October 7, 2024 14:04
8476b90
to
4a78946
Compare
This pull request was exported from Phabricator. Differential Revision: D63976936 |
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
This pull request has been merged in 11fefbb. |
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Oct 7, 2024
Summary: sapling github CI had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github, so lets give fb303 a CI. * add a github action to build fb303 * delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine. (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed) X-link: facebook/fb303#58 X-link: facebookincubator/zstrong#1006 Reviewed By: singhsrb Differential Revision: D63976936 fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
add a github action so its visible if fb303 compiles externally
sapling github CI wangle step wangle had a failure in github CI on fb303 and I wasn't sure if fb303 was itself building ok.
Differential Revision: D63976936