Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github CI signal #58

Closed
wants to merge 1 commit into from
Closed

Conversation

ahornby
Copy link
Contributor

@ahornby ahornby commented Oct 7, 2024

Summary:
add a github action so its visible if fb303 compiles externally

sapling github CI wangle step wangle had a failure in github CI on fb303 and I wasn't sure if fb303 was itself building ok.

Differential Revision: D63976936

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63976936

ahornby added a commit to ahornby/fb303 that referenced this pull request Oct 7, 2024
Summary:

add a github action so its visible if fb303 compiles externally

sapling github CI wangle step wangle had a failure in github CI on fb303 and I wasn't sure if fb303 was itself building ok.

Differential Revision: D63976936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63976936

Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.


Differential Revision: D63976936
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63976936

ahornby added a commit to ahornby/sapling that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936
facebook-github-bot pushed a commit to facebook/fbthrift that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebook/openr that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebook/folly that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebook/wangle that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebookincubator/hsthrift that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebook/mvfst that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebook/sapling that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebookexperimental/edencommon that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebook/watchman that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebookincubator/katran that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 11fefbb.

facebook-github-bot pushed a commit to facebookincubator/fizz that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebook/hhvm that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebook/fboss that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebook/proxygen that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebookexperimental/moxygen that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
facebook-github-bot pushed a commit to facebookexperimental/rust-shed that referenced this pull request Oct 7, 2024
Summary:
sapling github CI  had a failure on fb303 and I wasn't sure if fb303 was itself building ok on github,  so lets give fb303 a CI.

* add a github action to build fb303
* delete fb303 github side packit config [as it is broken](https://github.com/facebook/fb303/pull/58/checks?check_run_id=31169950255). For folly packit was moved to copr side in D54958528 so I think this is fine.

 (the underlying problem causing a transient [fb303 break in sapling CI](https://github.com/facebook/sapling/actions/runs/11213566522/job/31166881318?pr=963) was that build/deps/github_hashes/facebook/fbthrift-rev.txt was lagging the code using fbthrift, and thus python libs where not installed)

X-link: facebook/fb303#58
X-link: facebookincubator/zstrong#1006

Reviewed By: singhsrb

Differential Revision: D63976936

fbshipit-source-id: 4601874a993b0e7253954815f6f119ea351f5c6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants