Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shallowEqual returns true when dealing with NaN #102

Closed

Conversation

rickbeerendonk
Copy link

Fixes #101

@dashed
Copy link

dashed commented Jan 9, 2016

@rickbeerendonk
Copy link
Author

@dashed That is a different issue, but you are correct in that it should also be handled.

@rickbeerendonk rickbeerendonk changed the title shallowEqual returns true when equal keys both have value NaN shallowEqual returns true when dealing with NaN Jan 9, 2016
@syranide
Copy link

syranide commented Jan 9, 2016

I'm not sure how perf-critical this is, but it could be worth considering A === B || Object.is(A, B) if it is.

@zpao
Copy link
Member

zpao commented Jan 11, 2016

Thanks for doing this however… I'm going to close out because we already have this change internally and will be part of the next sync out. Sorry it's not already here - I need to be careful when it gets synced out for compatibility reasons

@zpao zpao closed this Jan 11, 2016
@rickbeerendonk
Copy link
Author

@zpao Thank you for explaining, no worries.

@rickbeerendonk rickbeerendonk deleted the shallowEqual-NaN branch January 11, 2016 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants