Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Commit

Permalink
Use correct bounds for litho debug components
Browse files Browse the repository at this point in the history
Summary:
This change is a follow-up on Litho release:
https://central.sonatype.dev/artifact/com.facebook.litho/litho-widget-kotlin/0.44.0

This change ensures DebugComponent returns the correct Bounds.

Reviewed By: aigoncharov

Differential Revision: D40678191

fbshipit-source-id: 1d587efa114a9cd5c0b8162d219e93e3cbad282e
  • Loading branch information
lblasa authored and facebook-github-bot committed Oct 28, 2022
1 parent 587f428 commit 3598fb2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ class DebugComponentDescriptor(val register: DescriptorRegister) : NodeDescripto

override fun getData(node: DebugComponent) = mapOf<String, InspectableObject>()

override fun getBounds(node: DebugComponent): Bounds = Bounds.fromRect(node.bounds)
override fun getBounds(node: DebugComponent): Bounds =
Bounds.fromRect(node.boundsInParentDebugComponent)

override fun getTags(node: DebugComponent): Set<String> = setOf(BaseTags.Declarative, LithoTag)

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ POM_DEVELOPER_ID=facebook
POM_DEVELOPER_NAME=facebook
POM_ISSUES_URL=https://github.com/facebook/flipper/issues/
# Shared version numbers
LITHO_VERSION=0.43.0
LITHO_VERSION=0.44.0
ANDROIDX_VERSION=1.3.0
KOTLIN_VERSION=1.6.20
# Gradle internals
Expand Down

0 comments on commit 3598fb2

Please sign in to comment.