Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Commit

Permalink
Move bolts dependencies to Fresco plugin (#1937)
Browse files Browse the repository at this point in the history
Summary:
Fixes #1919

Somehow the diff author put the dependencies in the root `build.gradle`, which is unnecessary as this is only used by Fresco.

Pull Request resolved: #1937

Test Plan:
Built the sample app, checked that the Fresco stuff continues to work.
![Screenshot_1613565381](https://user-images.githubusercontent.com/9906/108205459-0366ef80-711d-11eb-8b3b-f804f02622af.png)

Reviewed By: mweststrate

Differential Revision: D26483701

Pulled By: passy

fbshipit-source-id: 88f056ed0897f2c00844e02721eb45d5b85c6908
  • Loading branch information
passy authored and facebook-github-bot committed Feb 18, 2021
1 parent e3d1e41 commit b25de27
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
3 changes: 0 additions & 3 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ android {
testImplementation deps.testRules
testImplementation deps.hamcrest
testImplementation deps.junit

api 'com.parse.bolts:bolts-tasks:1.4.0'
api 'com.parse.bolts:bolts-applinks:1.4.0'
}
}

Expand Down
3 changes: 3 additions & 0 deletions android/plugins/fresco/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ android {
implementation deps.frescoFlipper
compileOnly deps.jsr305

api deps.boltsTasks
api deps.boltsApplinks

// Exclude the actual stetho dep as we only want some of the fresco APIs here
implementation(deps.frescoStetho) {
exclude group: 'com.facebook.stetho'
Expand Down
2 changes: 2 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ ext.deps = [
// First-party
soloader : 'com.facebook.soloader:soloader:0.10.1',
screenshot : 'com.facebook.testing.screenshot:core:0.5.0',
boltsTasks : 'com.parse.bolts:bolts-tasks:1.4.0',
boltsApplinks : 'com.parse.bolts:bolts-applinks:1.4.0',
// Annotations
jsr305 : 'com.google.code.findbugs:jsr305:3.0.2',
inferAnnotations : 'com.facebook.infer.annotation:infer-annotation:0.11.2',
Expand Down

0 comments on commit b25de27

Please sign in to comment.