-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: "Opting out from Flipper" and "Disable Flipper on CI builds" in React Native should be updated since the Podfile changed in react-native 0.69.2 #3995
Comments
Related issue: jakobo/expo-community-flipper#18 |
When disabling via This issue is related. This is blocking for us because we can't build via AppCenter with Flipper (surpassing 60 minutes 🙄 ) |
hmm thats wierd. i just decided to disable flipper the same way as you since i wasent using it, and appcenter works fine for me still. |
The iOS compile error originates from the package with javascript bindings to add plugins: So I guess only those who use Flipper plugins (like the redux plugin) are seeing this error. |
Solution is easy: // react-native.config.js
module.exports = {
dependencies: {
...(process.env.CI ? { 'react-native-flipper': { platforms: { ios: null } } } : {}),
},
project: {
ios: {},
android: {},
},
}; see more in a Troubleshooting part : https://dev.to/retyui/disable-flipper-on-ci-builds-for-react-native-complete-guide-bnd |
to turn off Flipper on CI you can do next: # ./ios/Podfile
use_react_native!(
:flipper_configuration => ENV['CI'] ? FlipperConfiguration.disabled : FlipperConfiguration.enabled, |
…ld fail (#35686) Summary: - Flipper issue: facebook/flipper#3995 (comment) iOS build fail with an error: ```sh node_modules/react-native-flipper/ios/FlipperReactNativeJavaScriptPlugin.h:9:9: 'FlipperKit/FlipperConnection.h' file not found #import <FlipperKit/FlipperConnection.h> ``` ## Changelog [IOS] [FIXED] - Exclude `react-native-flipper` when `NO_FLIPPER=1` to prevent iOS build fail Pull Request resolved: #35686 Test Plan: ```sh npx react-native init RN0710RC5 --version 0.71.0-rc.5 cd RN0710RC5 yarn add react-native-flipper NO_FLIPPER=1 pod install --project-directory=ios yarn ios # will fail ``` Reviewed By: rshest Differential Revision: D42368444 Pulled By: cipolleschi fbshipit-source-id: a8614ccadb98970ebae15d8743136fa60ead318c
…ld fail (#35686) Summary: - Flipper issue: facebook/flipper#3995 (comment) iOS build fail with an error: ```sh node_modules/react-native-flipper/ios/FlipperReactNativeJavaScriptPlugin.h:9:9: 'FlipperKit/FlipperConnection.h' file not found #import <FlipperKit/FlipperConnection.h> ``` ## Changelog [IOS] [FIXED] - Exclude `react-native-flipper` when `NO_FLIPPER=1` to prevent iOS build fail Pull Request resolved: #35686 Test Plan: ```sh npx react-native init RN0710RC5 --version 0.71.0-rc.5 cd RN0710RC5 yarn add react-native-flipper NO_FLIPPER=1 pod install --project-directory=ios yarn ios # will fail ``` Reviewed By: rshest Differential Revision: D42368444 Pulled By: cipolleschi fbshipit-source-id: a8614ccadb98970ebae15d8743136fa60ead318c
There's a very nice article which helped me a lot. Original article: https://dev.to/retyui/disable-flipper-on-ci-builds-for-react-native-complete-guide-bnd |
@andac-ozcan |
Sorry about that. I just updated my post 🙏 |
…ld fail (facebook#35686) Summary: - Flipper issue: facebook/flipper#3995 (comment) iOS build fail with an error: ```sh node_modules/react-native-flipper/ios/FlipperReactNativeJavaScriptPlugin.h:9:9: 'FlipperKit/FlipperConnection.h' file not found #import <FlipperKit/FlipperConnection.h> ``` ## Changelog [IOS] [FIXED] - Exclude `react-native-flipper` when `NO_FLIPPER=1` to prevent iOS build fail Pull Request resolved: facebook#35686 Test Plan: ```sh npx react-native init RN0710RC5 --version 0.71.0-rc.5 cd RN0710RC5 yarn add react-native-flipper NO_FLIPPER=1 pod install --project-directory=ios yarn ios # will fail ``` Reviewed By: rshest Differential Revision: D42368444 Pulled By: cipolleschi fbshipit-source-id: a8614ccadb98970ebae15d8743136fa60ead318c
@andac-ozcan Thank you for sharing the article! It is very helpful indeed. @retyui I was wondering, in react-native 0.71 version, there is no need to define the pod installation: For example, I use App Center. I just have to define the I suppose that in case someone defines exactly all the build steps (npm or pod dependencies installation), then they also have to include the Mentioning it, because it is not fully clear in the article. |
for these 2:
https://fbflipper.com/docs/getting-started/troubleshooting/react-native/#opting-out-from-flipper-ios
https://fbflipper.com/docs/getting-started/troubleshooting/react-native/#disable-flipper-on-ci-builds-ios
they show:
however, since react-native 0.69.2, the Podfile has been changed so those examples no longer work.
the changes can be seen upgrade helper from 0.69.1 to 0.69.2: https://react-native-community.github.io/upgrade-helper/?from=0.69.1&to=0.69.2
the current examples could stay, as they are still relevant to react-native projects running a version less than 0.69.2. i suggest adding new examples for the new Podfile syntax.
i assume the change for opting out of flipper would be(though im not sure since i could find anything about the
FlipperConfiguration
variable):and to disable in CI(this may be incorrect and is just a guess.
just tested the above code and i get errors related to invalid Podfile syntax when running "pod install". so this is probably not a good way to do it
you could probably also change the enabled/disabled variable. though im not familiar with ruby so i wouldt know exactly how to change that value.
i think i could do these changes. what do the maintainers think about this change?
The text was updated successfully, but these errors were encountered: