Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Network Plugin - Add remaining HTTP method types to mock routes #1962

Closed
wants to merge 1 commit into from
Closed

Network Plugin - Add remaining HTTP method types to mock routes #1962

wants to merge 1 commit into from

Conversation

bizzguy
Copy link
Contributor

@bizzguy bizzguy commented Feb 24, 2021

Summary

Currently, mock routes can only be created for GET and POST HTTP method types. Mocks should support all the valid HTTP method types.

See specification for a list of valid types:

https://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html

This was requested in issue: #1960

Here is a screen shot showing the new values added to the select list:

image

Changelog

Network Plugin - support all valid HTTP method types in mock routes

Test Plan

Define mock routes using additional method types
Using "Flipper Messages" plugin, verify that new types have been sent to device

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 24, 2021
@coveralls
Copy link

coveralls commented Feb 24, 2021

Pull Request Test Coverage Report for Build 595046266

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 45.345%

Totals Coverage Status
Change from base Build 593030406: -0.005%
Covered Lines: 6072
Relevant Lines: 12145

💛 - Coveralls

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mweststrate has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mweststrate
Copy link
Contributor

Thanks once again @bizzguy!

@passy
Copy link
Member

passy commented Feb 26, 2021

Nice! Thanks a ton for adding this so quickly!

@facebook-github-bot
Copy link
Contributor

@mweststrate merged this pull request in 4da2b52.

@bizzguy bizzguy deleted the mock-method-types branch February 26, 2021 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants