Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow v0.57.x is not stable #5105

Closed
apsavin opened this issue Oct 14, 2017 · 2 comments
Closed

Flow v0.57.x is not stable #5105

apsavin opened this issue Oct 14, 2017 · 2 comments

Comments

@apsavin
Copy link
Contributor

apsavin commented Oct 14, 2017

For example, I can remove react-redux_v5.x.x.js from flow-typed/npm folder and flow will not complain.

But if I'll change something else - for example, if I'll remove passing of a required prop of a React Component to check if flow will find the error - flow will start to see that there's no react-redux libdefs.

Flow 0.56 worked as expected: started to complain right after remove of libdefs.
@steida steida mentioned this issue Oct 15, 2017
Closed
@apsavin
Copy link
Contributor Author

apsavin commented Oct 16, 2017

I'm still experiencing this with 0.57.3

@apsavin apsavin changed the title Flow v0.57.2 is not stable Flow v0.57.x is not stable Oct 16, 2017
This was referenced Oct 17, 2017
Closed
Closed
@gin0606 gin0606 mentioned this issue Oct 25, 2017
Closed
@apsavin
Copy link
Contributor Author

apsavin commented Nov 4, 2017

Closing because of #5180

@apsavin apsavin closed this as completed Nov 4, 2017
@omeid omeid mentioned this issue Feb 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apsavin