Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow check vs flow focus-check yields different results #5125

Closed
avaly opened this issue Oct 17, 2017 · 4 comments
Closed

flow check vs flow focus-check yields different results #5125

avaly opened this issue Oct 17, 2017 · 4 comments

Comments

@avaly
Copy link

avaly commented Oct 17, 2017

Using flow 0.57.3, I get the following output running flow check:

$ flow check
Found 0 errors

And when running flow focus-check for a file:

$ flow focus-check client/app/pages/builds/BuildsPage.react.js
[2017-10-17 22:16:59] Checking 1 files
[2017-10-17 22:16:59] executable=/home/avaly/.config/yarn/global/node_modules/flow-bin/flow-linux64-v0.57.3/flow
[2017-10-17 22:16:59] version=0.57.3
[2017-10-17 22:16:59] Parsing
[2017-10-17 22:16:59] Building package heap
[2017-10-17 22:16:59] Loading libraries
[2017-10-17 22:17:00] Resolving dependencies
[2017-10-17 22:17:00] to_merge: Focused: 1, Dependents: 1, Dependencies: 56
[2017-10-17 22:17:00] Calculating dependencies
[2017-10-17 22:17:00] Merging
[2017-10-17 22:17:00] Done
[2017-10-17 22:17:00] Checked set: Focused: 1, Dependents: 1, Dependencies: 56
Error: client/app/pages/builds/BuildsPage.react.js:39
 39: 			<AppPage sideBar={<ProjectsListConnector />} title={t('builds.title')}>
     			                  ^^^^^^^^^^^^^^^^^^^^^^^^^ React element `ProjectsListConnector`
 39: 			<AppPage sideBar={<ProjectsListConnector />} title={t('builds.title')}>
     			                  ^^^^^^^^^^^^^^^^^^^^^^^^^ props of React element `ProjectsListConnector`. This type is incompatible with
 25: 	InputProps: AppAuthenticatedPropsType,
     	            ^^^^^^^^^^^^^^^^^^^^^^^^^ object type. See: client/app/components/decorators/authenticated.js:25
  Property `account` is incompatible:
     25: 	InputProps: AppAuthenticatedPropsType,
         	            ^^^^^^^^^^^^^^^^^^^^^^^^^ property `account`. Property not found in. See: client/app/components/decorators/authenticated.js:25
     39: 			<AppPage sideBar={<ProjectsListConnector />} title={t('builds.title')}>
         			                  ^^^^^^^^^^^^^^^^^^^^^^^^^ props of React element `ProjectsListConnector`

...

Found 4 errors

I'm not sure exactly which result is correct, whether flow check missed an error or whether flow focus-check is wrong.

@avaly
Copy link
Author

avaly commented Oct 17, 2017

Running on the same codebase with flow 0.56.0: both flow check and flow focus-check FILE return the same errors from above.

@apsavin
Copy link
Contributor

apsavin commented Oct 17, 2017

Maybe related to #5105

@apsavin
Copy link
Contributor

apsavin commented Nov 4, 2017

@avaly see #5180

@avaly
Copy link
Author

avaly commented Nov 7, 2017

Indeed this issue seems to have been triggered by my usage of resolve_dirname option. It seems that changing the config like in #5180 (comment) seems to fix the issue in flow 0.58.0.

@avaly avaly closed this as completed Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants