Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type ReactDOM.render to correctly indicate that it may return null #5728

Closed
wants to merge 1 commit into from
Closed

Type ReactDOM.render to correctly indicate that it may return null #5728

wants to merge 1 commit into from

Conversation

jeffchan
Copy link

It's possible for ReactDOM.render to return null.

See issue: facebook/react#10309 (comment)
And demo: https://jsfiddle.net/x7c7bdh0/

@yns88 yns88 removed the cla signed label Mar 28, 2018
@nmote nmote added the Library definitions Issues or pull requests about core library definitions label Jan 3, 2019
@nmote nmote added the react label Feb 6, 2019
@goodmind goodmind added the Stalled Issues and PRs that are stalled. label Jul 27, 2019
@Brianzchen
Copy link
Contributor

react-dom has been moved to flow-typed, if you're still interested in this change you raise a PR to change it there
https://github.com/flow-typed/flow-typed/blob/master/definitions/npm/react-dom_v16.x.x/flow_v0.117.x-/react-dom_v16.x.x.js#L10

@Brianzchen Brianzchen closed this Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Library definitions Issues or pull requests about core library definitions react Stalled Issues and PRs that are stalled.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeffchan @Brianzchen @yns88 @goodmind @facebook-github-bot @nmote