[getdeps] restore rpm system deps for fedora #2231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL Test Plan: Build locally on fedora 40: ``` ./build/fbcode_builder/getdeps.py install-system-deps --recursive folly ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. folly ```
|
@ahornby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Jun 10, 2024
Summary: [getdeps] restore rpm system deps for fedora centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers. Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely. Also: * fedora has up to date gtest & gmock, so use them * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names. F37 is EOL X-link: facebook/folly#2231 Reviewed By: HarveyHunt Differential Revision: D58324546 Pulled By: ahornby fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[getdeps] restore rpm system deps for fedora
Summary:
centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855. Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers.
Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely.
Also:
Test Plan:
Build locally on fedora 40: