Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefine clearenv() on FreeBSD #2338

Closed
wants to merge 1 commit into from
Closed

Undefine clearenv() on FreeBSD #2338

wants to merge 1 commit into from

Conversation

yurivict
Copy link
Contributor

No description provided.

@yurivict yurivict mentioned this pull request Nov 12, 2024
Open
@facebook-github-bot
Copy link
Contributor

@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Orvid merged this pull request in bbf3632.

facebook-github-bot pushed a commit to facebook/hhvm that referenced this pull request Nov 13, 2024
@yurivict @facebook-github-bot
Undefine clearenv() on FreeBSD (#2338)
f6c56a4 
Summary: Pull Request resolved: facebook/folly#2338

Reviewed By: Gownta

Differential Revision: D65834747

Pulled By: Orvid

fbshipit-source-id: e74cfbcf43bbd94dca4fac1a8908005a3ce2ce20
@yurivict
Copy link
Contributor Author

@Orvid

Hi Orvid,

There is another problem is that #include <stdlib.h> is missing in system/EnvUtil.cpp for clearenv().

log

Could you please add it?

@Orvid
Copy link
Contributor

Orvid commented Nov 18, 2024 •
edited
Loading

system/EnvUtil.cpp already includes folly/portability/Stdlib.h, which includes cstdlib. Our portability headers that are named after standard library headers, are explicitly defined to always include the standard library header it's named after, if it's available on the current platform.

Does FreeBSD not expose clearenv via cstdlib for some reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yurivict @facebook-github-bot @Orvid