-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Correct Zstd capitalization in FindZstd.cmake #2379
Closed
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Differential Revision: D69284782
This pull request was exported from Phabricator. Differential Revision: D69284782 |
This pull request was exported from Phabricator. Differential Revision: D69284782 |
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebook/CacheLib
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
This pull request has been merged in ee60b26. |
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Feb 8, 2025
Summary: X-link: facebook/folly#2379 This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library. Tested on Cmake 3.28.3 X-link: facebookincubator/zstrong#1170 Reviewed By: terrelln Differential Revision: D69284782 fbshipit-source-id: 4acc32705ae937f075e1531cae3449cfae0d84ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit addresses a CMake warning due to inconsistent capitalization of the Zstd package name in FindZstd.cmake. This fixes issues with finding and using the Zstd library.
Tested on Cmake 3.28.3
X-link: https://github.com/facebookincubator/zstrong/pull/1170
Differential Revision: D69284782