Share Element Gone after do SharedElementReturnTransition in Android N

[changety]

I use the newest fresco code for doing SharedElement Transition work， it runs well in Android L、M， But on Android N, it goes wrong

before transition

after transition

[aagnes-zz]

Can you please show how you do the transition part using Fresco's demo app?

[changety]

activity_main.xml and activity_detail� has same SimpleDraweeView with same transitionName
and in DetailActivity’s onCreate method as below:

protected void onCreate(Bundle savedInstanceState) {
getWindow().requestFeature(Window.FEATURE_CONTENT_TRANSITIONS);
getWindow().setSharedElementEnterTransition(DraweeTransition.createTransitionSet(ScalingUtils.ScaleType.CENTER_CROP, ScalingUtils.ScaleType.FIT_CENTER));
getWindow().setSharedElementReturnTransition(DraweeTransition.createTransitionSet(ScalingUtils.ScaleType.FIT_CENTER, ScalingUtils.ScaleType.CENTER_CROP));
addTransitionListener();
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_detail);
mBaselineJpegView = (SimpleDraweeView) findViewById(R.id.baseline_jpeg);
mBaselineJpegView.setImageURI(Uri.parse("https://www.gstatic.com/webp/gallery/1.sm.jpg"));
mBaselineJpegView.setOnClickListener(new View.OnClickListener() {
@OverRide
public void onClick(View v) {
Toast.makeText(DetailActivity.this, "dsasa", Toast.LENGTH_LONG).show();
}
});
}

addTransitionListener() does nothing just print log

so do I use wrong way to do the transition? �

[raylee4204]

This is happening to me as well.

I have the following in onCreate() method before super.onCreate()

supportRequestWindowFeature(Window.FEATURE_CONTENT_TRANSITIONS);
Transition fade = new Fade();
fade.excludeTarget(android.R.id.statusBarBackground, true);
fade.excludeTarget(android.R.id.navigationBarBackground, true);
Window window = getWindow();
window.setEnterTransition(fade);
window.setReturnTransition(fade);
window.setExitTransition(fade);
TransitionSet transitionSet = DraweeTransition
                    .createTransitionSet(ScalingUtils.ScaleType.CENTER_CROP,
ScalingUtils.ScaleType.CENTER_CROP);
window.setSharedElementEnterTransition(transitionSet);
window.setSharedElementExitTransition(transitionSet);

[mihaicristianpetrescu]

I'm experiencing the same issue. The setSharedElementReturnTransition is not working on Android N. I've added logs to the transition listeners and the onTransitionStart and onTransitionEnd are not triggered on Android N, but on Android M & L it works just fine.
I'm using the latest version of the Fresco library com.facebook.fresco:fresco:0.14.1 with com.facebook.fresco:imagepipeline-okhttp3:0.14.1
I don't have this issue if I use Picasso library for loading the image.
The scenario is similar: gridView, gridItem navigates away to another Activity (everything is fine on this part) but when I go back, there is no reenter, the image flashes and is reloaded (the placeholder image is not visible nor the image that was already loaded). This only happens on Android N (7.0)

[raylee4204]

Any update on this issue?

[mihaicristianpetrescu]

Switched from Fresco to Picasso and the issue is resolved. Too bad this library isn't maintained as often as required by the new Android OS versions that come out.

[SanderTuit]

It seems that this issue is incorrectly marked as 'needs-details'. This problem also exists on Android 7.1.1 (API level 25).

[oprisnik]

Thanks, we'll take a look

[tnache]

I am also experiencing the same problem, so +1 from me for fixing it.

[copa]

same here

[sbo3000]

Do it. Do it. ;-)

[cyrata]

Yes, please do it.

[pinkred]

Please...

[aldasa]

+1

[raylee4204]

Wonder why this isn't a high priority..

[zhuitian90]

+1

[stanmots]

When I scroll to the shared element position in onActivityReenter the disappeared item is coming back though with a little white flickering:

    @Override
    public void onActivityReenter(int resultCode, Intent data) {
        super.onActivityReenter(resultCode, data);

        final int position = data.getIntExtra(EXTRA_GIF_POSITION, -1);
        if (resultCode == RESULT_OK && position != -1) {
            gifRecyclerView.getLayoutManager().scrollToPosition(position);
        }
    }

If someone knows a better fix I would appreciate if you could share it.

[dimivrn]

Hello, i am experiencing the same issue but only on Android 7.1.1 API 25

If there are any updates about the issue i would highly appreciate it.

[FioneraGH]

same here on emu with 7.x, but I use onWindowFocusChanged be immersive, when finish occured the image will disappear but reshow instantly.

[bblackbelt]

Same here. Calling requestLayout on the View containing the SimpleDraweeView seems fixing it with some flickering. Please advise

[ibyxz]

Just add this code in calling activity，+1 if this can help you!!! @oprisnik

setExitSharedElementCallback(new SharedElementCallback() {

            @Override
            public void onSharedElementEnd(List<String> sharedElementNames,
                                           List<View> sharedElements,
                                           List<View> sharedElementSnapshots) {

                super.onSharedElementEnd(sharedElementNames, sharedElements,
                        sharedElementSnapshots);
                
                for (View view : sharedElements) {
                    if (view instanceof SimpleDraweeView) {
                        view.setVisibility(View.VISIBLE);
                    }
                }
            }
        });

[mengoni]

same problem here... @antxyz I've put your code in both calling and callee activities onCreate method but with no success. The shared element image is still invisible after returning transition.

[mengoni]

I don't know If it can help to find a solution, but I noticed that when softkeyboard is opened, the SimpleDraweeView become visible.

[fernando-jascovich]

I was having the same problem and it was fixed after this two calls:

1. Just before startActivity(...:

	setExitSharedElementCallback(new SharedElementCallback() {
				@Override
				public void onSharedElementEnd(List<String> names,
											   List<View> elements,
											   List<View> snapshots) {
					super.onSharedElementEnd(names, elements, snapshots);
					for (final View view : elements) {
						if (view instanceof SimpleDraweeView) {
							view.post(() ->	view.setVisibility(View.VISIBLE));
						}
					}
				}
			});

2. Inside the onCreate of the new activity:

setEnterSharedElementCallback(new SharedElementCallback() {
				@Override
				public void onSharedElementEnd(List<String> names,
											   List<View> elements,
											   List<View> snapshots) {
					super.onSharedElementEnd(names, elements, snapshots);
					for (final View view : elements) {
						if (view instanceof SimpleDraweeView) {
							view.post(() -> view.setVisibility(View.VISIBLE));
						}
					}
				}
			});

[luckyleongao]

@oprisnik I finally found the cause of my problem.
In case of misunderstanding other people, I'm here to give some explanations.
My issue has sth to do with the picture format.
If I use the method imageRequestBuilder.setProgressiveRenderingEnabled(true) with PNG format, my issue can always reproduce.
If I change the method to imageRequestBuilder.setProgressiveRenderingEnabled(false) with PNG format, everything works fine.
@oprisnik Thanks again for your patience!

[Fab-z4qx]

Please fix this issue...

[asos-davidf]

Fresco 1.9.0 doesn't fix the issue properly.
A mix of the propositions in this thread fixes it depending on the device:

• For a Google Pixel 2 (on 8.1), both setLegacyVisibilityHandlingEnabled alone and the onSharedElementEnd workaround alone work.
• For a Samsung Galaxy S6 (on 7.0), the legacy visibility does nothing but the onSharedElementEnd workaround works.

So I'm using both workarounds in my code to be safe in my code and hopefully that covers everything. @oprisnik I'll spend some time to try and understand the problem better, if I find a fix I'll submit a PR.

[oprisnik]

Yeah, unfortunately we still don't have a good fix for this issue since all solutions mentioned in this thread fail in one or the other way. If somebody has an idea on how to properly fix this, please let us know or, even better, submit a PR :)

[Fab-z4qx]

Still, this issue on react-native-maps component. I imagine it's a concurrent problem?
Do you have any idea of where is the problem?

[willbattel]

Any progress on pinpointing the issue? Seems we haven't hear anything since April.

[oprisnik]

We still did not have time to further investigate what's going on here. Feel free to look into the issue and submit a pull request!

[oprisnik]

As mentioned earlier, the underlying issue seems to be an Android framework bug where ImageView doesn't properly restore the visibility of the underlying Drawable when returning from the transition.

I've filed an Android bug report here: https://issuetracker.google.com/issues/111293868

I've also created a (non-Fresco) sample app that outlines the issue: https://github.com/oprisnik/VisibilityPlayground

We'll investigate if there is a workaround for this issue. However, Fresco requires manual memory management and we rely on the Drawable visibility to re-request the image, so I'm not sure if there is a better fix than the workarounds described above.

[Crysis21]

I switched to fresco not being aware of this issue. I render a ton of gifs and it does a great job, but I'm also dependent on these animations for navigation. I've been able to use the above mentioned hacks, but on a return animation, the image will disappear.

[RainFool]

Actually invalidate or View.setVisibility can not show drawable, you need call Drawable.setVisible(true, true) directly .
I add these codes in A Activity#OnCreate,it works fine:

ActivityCompat.setExitSharedElementCallback(this, new SharedElementCallback() {
            @Override
            public void onSharedElementEnd(List<String> sharedElementNames, List<View> sharedElements, List<View> sharedElementSnapshots) {
                super.onSharedElementEnd(sharedElementNames, sharedElements, sharedElementSnapshots);
                if (FP.empty(sharedElements)) {
                    return;
                }
                for (View view : sharedElements) {
                    if (view instanceof SimpleDraweeView) {
                        ((SimpleDraweeView) view).getDrawable().setVisible(true, true);
                    }
                }
            }
        });

[grahammendick]

@oprisnik In your non-fresco sample app you set the transition to ChangeBounds. Does the bug happen if you remove this line? I guess the visibility is restored correctly when the ChangeImageTransform is in play. Is it possible to get fresco images to work with the ChangeImageTransform?

[bu2zhouzhu]

@RainFool is right. simpleDraweeView.getVisibility() is VISIBLE, but simpleDraweeView.getDrawable().isVisible() is false.

[oprisnik]

Yes, this is a bug in the Android framework where the View visibility (ImageView to be precise) is not propagated to the Drawable, so you have to manually update visibility. Please star the Android bug report here so that this gets more visibility: https://issuetracker.google.com/issues/111293868