Should support VectorDrawable resource id

[ohshi000]

tag need support. v21 and AppCompat already support v9 and up api level.

[kirwan]

Where do you want to use VectorDrawable resource IDs?

Right now, Fresco will only load bitmaps for the primary image but for placeholders, backgrounds, overlays, loading drawables and failures they should work.

If you could give a small code snippet we can double check what your issue is.

[ohshi000]

This is a vector image on res/drawable/ic_arrow.xml
So i need load the vector image with Fresco.
SimpleDraweeView.setImageUri("res://package/id")

[ohshi000]

<vector xmlns:android="http://schemas.android.com/apk/res/android" android:width="24dp" android:height="24dp" android:viewportHeight="24.0" android:viewportWidth="24.0"> <path android:fillColor="#cccccc" android:pathData="M8.59,16.34l4.58,-4.59 -4.58,-4.59L10,5.75l6,6 -6,6z"/> </vector>

[kirwan]

DraweeView doesn't support VectorDrawables as the main image, only bitmaps. I think you would need to simply use an ImageView in this case.

DraweeView does extend ImageView but as the documentation on the class says, that shouldn't be taken as a sign that it supports everything that does.

[consp1racy]

DraweeViews support several XML attributes that load images from resources. The best and easiest way to extend functionality would be using

fun Context.getDrawableCompat(@DrawableRes resId: Int): Drawable? {
    try {
        // Public API recently introduced in AppCompat.
        return AppCompatResources.getDrawable(this, resId)
    } catch (ex: NoSuchMethodError) {
        try {
            // Private library API so far present in AppCompat at least since 23.4.0.
            return AppCompatDrawableManager.get().getDrawable(context, resId, false);
        } catch (ex: NoSuchMethodError) {
            // Fall back to platform handling.
            return ContextCompat.getDrawable(this, resId)
        }
    }
}

instead of plain

context.resources.getDrawable(...)

(Optimizations welcome.)

[marcosalis]

+1!
It's a pretty common scenario to need using a vector drawable in some cases instead of a Bitmap. The lack of support means that client code needs to handle this scenario manually, by setting a placeholder image in those cases. And this can be painful when views are recycled in an adapter, because it means you have to constantly reset the correct placeholder when the view is recycled...

[diegobarle]

@consp1racy please use ContextCompat to support getDrawable in old android versions:

ContextCompat.getDrawable(context, R.drawable.your_vector_drawable)

[consp1racy]

@diegobarle For two years I've been doing a whole lot more. Check the code sample again.

You may want to google what's the point of ContextCompat.getDrawable (it doesn't solve anything, it just hides an if-else check), when do you need it, and why you may want to use AppCompatResources.getDrawable instead (backport theme references and vector drawables). For example this SO question: https://stackoverflow.com/questions/43004886/resourcescompat-getdrawable-vs-appcompatresources-getdrawable