We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In our babel config, we define:
... plugins: [ 'babel-plugin-syntax-hermes-parser', ... ] ...
We also have this in our webpack build:
... splitChunks: { cacheGroups: { shared: { name: (module, chunks, cacheGroupKey) => { return `${cacheGroupKey}~${chunks .map((chunk) => chunk.name) .join('~')}`.slice(0, 109); }, ... }, ... }, ... }
If I add a log on the names generated, BEFORE: shared~chunkname~otherchunkname AFTER: shared~~.
shared~chunkname~otherchunkname
shared~~
The only change I'm making to our codebase is to add the plugin to the babel.config.js
The parser should not drop chunk names
The text was updated successfully, but these errors were encountered:
I figured out the basic issue, which is that the babel parser preserves comments, but the hermes parser doesn't
import( /* webpackChunkName: 'chunk.name' */ "./file");
import("./file")
Sorry, something went wrong.
Hello,
just hit the exact same issue :)
pieterv
No branches or pull requests
Bug Description
In our babel config, we define:
We also have this in our webpack build:
If I add a log on the names generated, BEFORE:
shared~chunkname~otherchunkname
AFTER:shared~~
.The only change I'm making to our codebase is to add the plugin to the babel.config.js
The parser should not drop chunk names
The text was updated successfully, but these errors were encountered: