Make Hermes parser optional #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalduez
force-pushed
the
feature/hermes-optional
branch
from
43a8fce to
6aa14d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option for parser switch, between
babelandhermes.Revert the use of Hermes parser by default.
This will hopefully help us adopt it gradually.
Some of the issues we face:
facebook/hermes#1320 (used by Webpack)
facebook/hermes#1098 (used by Storybook, react-docgen)
Another one hard to refine while deploying our StoryBook
storybook build.Also split the tests and fixtures so it's easier to test different scenarios.