-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hermes crashes on attempt to emit binary to the same destination #45
Labels
bug
Something isn't working
Comments
facebook-github-bot
pushed a commit
that referenced
this issue
Jul 19, 2019
Summary: This fixes a bug when the input and output of the compiler are the same filename. It was possible for the compiler to try to read source lines from the JS file to print a warning, when the file had already been truncated and/or overwritten with bytecode. On linux, this would blow up. #45 includes a repro. This also updates some tests which used -out /dev/null which will no longer work, as /dev/null.@@@@@@ cannot be created. Reviewed By: avp Differential Revision: D16383966 fbshipit-source-id: feed4f830d8f9d1a36fc162f6d15d0e963d8d72f
hermes-engine 0.1.1 is out with mhorowitz's fix |
facebook-github-bot
pushed a commit
that referenced
this issue
Feb 22, 2021
Summary: I released the new version a while ago. Better to stay in sync. Pull Request resolved: facebookincubator/fbjni#45 Test Plan: ./gradlew assemble scripts/run-host-tests.sh Reviewed By: mweststrate Differential Revision: D26544925 Pulled By: passy fbshipit-source-id: 358cee2bdd49f612ede0c611287ff757d113b096
Closed
1 task
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
UPD: The bug looks Linux-specific.
Steps to reproduce
hermes
binary.Expected result
The original bundle file should be replaced with the emitted binary.
Actual result
Crash:
Environment
The text was updated successfully, but these errors were encountered: