Fix wasm optimization compilation errors #1134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@tmikov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tmikov
reviewed
Oct 4, 2023
| @@ -20,6 +20,7 @@ add_hermes_library(hermesOptimizer | |||
| Optimizer/Scalar/InstSimplify.cpp | |||
| Optimizer/Scalar/Auditor.cpp | |||
| Optimizer/Wasm/WasmSimplify.cpp | |||
| Optimizer/Wasm/EmitWasmIntrinsics.cpp | |||
There was a problem hiding this comment.
If we are moving EmitWasmIntrinsics into the optimizer lib, it should be removed from the frontend lib below.
|
Closing, since no response from PR author in two weeks. |
|
Ah sorry, missed the message. |
|
@farwayer has updated the pull request. You must reimport the pull request before landing. |
|
@tmikov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For now enabling the HERMES_RUN_WASM flags causes compilation errors