Stop inconsistently using the TypedNum alias for TypedValue

Summary: We have an alias for TypedValue called TypedNum, which is supposed to mean the TV contains an int or double (but this is by convention only, there is no enforcement or behavior change). This was only applied in a handful of places, and the ony ones left were tvSub and tvMul from tv-arith.{h,cpp}, a tiny fraction of the places where we have such TypedValues. At this point it's more confusing than helpful, so delete the alias and just use the TypedValue type.

Reviewed By: paulbiss

Differential Revision: D40093634

fbshipit-source-id: a7ec457f5f40dfe464ecd1ed54af4430ec426308

hphp/runtime/base/tv-arith.cpp

@@ -388,11 +388,11 @@ TypedValue tvAdd(TypedValue c1, TypedValue c2) {
   return tvArith(Add(), c1, c2);
 }
 
-TypedNum tvSub(TypedValue c1, TypedValue c2) {
+TypedValue tvSub(TypedValue c1, TypedValue c2) {
   return tvArith(Sub(), c1, c2);
 }
 
-TypedNum tvMul(TypedValue c1, TypedValue c2) {
+TypedValue tvMul(TypedValue c1, TypedValue c2) {
   return tvArith(Mul(), c1, c2);
 }
 

hphp/runtime/base/tv-arith.h

@@ -42,8 +42,8 @@ TypedValue tvAdd(TypedValue, TypedValue);
  *
  * These arithmetic operators on any php value only return numbers.
  */
-TypedNum tvSub(TypedValue, TypedValue);
-TypedNum tvMul(TypedValue, TypedValue);
+TypedValue tvSub(TypedValue, TypedValue);
+TypedValue tvMul(TypedValue, TypedValue);
 
 /*
  * PHP operators / and %.
@@ -57,7 +57,7 @@ TypedValue tvMod(TypedValue, TypedValue);
 /*
  * PHP Operator **.
  *
- * Always returns a TypedNum.
+ * Always returns KindOfInt64 or KindOfDouble.
  */
 TypedValue tvPow(TypedValue, TypedValue);
 

hphp/runtime/base/typed-value.h

@@ -235,11 +235,6 @@ struct TypedValueAux : TypedValue {
  */
 constexpr size_t kTVSimdAlign = 0x10;
 
-/*
- * A TypedNum is a TypedValue that is either KindOfDouble or KindOfInt64.
- */
-using TypedNum = TypedValue;
-
 ///////////////////////////////////////////////////////////////////////////////
 
 /*