Refactor steam_metadata() related code in UserFile. #4388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinxucs
force-pushed
the
stream-metadata-refactor
branch
from
ab0285a
to
04dac19
Compare
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D29865 |
Refactor steam_metadata() related code in UserFile so that only the overloaded metadata(path, option, value) is exposed instead of multiple functions (i.e. touch(), chmod(), chown(), chgrp()), which simplies the code.
kevinxucs
force-pushed
the
stream-metadata-refactor
branch
from
04dac19
to
c774b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor steam_metadata() related code in UserFile so that only the overloaded metadata(path, option, value) is exposed instead of multiple functions (i.e. touch(), chmod(), chown(), chgrp()), which simplies the code.