Allow parallelism on Windows. #6137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D45423 |
ghost
force-pushed
the
ocp-windows-sharing
branch
7 times, most recently
from
adf80f1 to
a3c9e1b
Compare
ghost
force-pushed
the
ocp-windows-sharing
branch
3 times, most recently
from
7ba366a to
dc17654
Compare
ghost
force-pushed
the
ocp-windows-sharing
branch
3 times, most recently
from
9f3c5ec to
90742cb
Compare
ghost
force-pushed
the
ocp-windows-sharing
branch
from
90742cb to
1f10090
Compare
This patch fixes the Windows-7 version, because the shared memory location was not correct.
On Windows, a new slave is 'spawned' for each request. But we still want to preserve the log files.
ghost
force-pushed
the
ocp-windows-sharing
branch
from
1f10090 to
6bb315c
Compare
These 'over-protective' tests are not useful: there is a fallback case just after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial rewrite of
worker.mlthat removes most of theObj.magic. This also use the newDaemon.spawnprimitive. On Windows, the slaves are not 'preforked' but a new slave process is created for each computation.