Fix compilation error with OpenSSL 3 #9288
Conversation
Summary: In OpenSSL 3, `EVP_PKEY_get0_*` functions now return `const` pointers, breaking existing usage depending on mutable pointers returned by OpenSSL 1.x. This diff fix the errors 1. Use `auto` type for return type of `EVP_PKEY_get0_*` functions instead of mutable pointer types. 1. Some `EVP_PKEY_get0_RSA` are replaced with `EVP_PKEY_get1_RSA` in order to get a mutable pointer with the ownership. See https://www.openssl.org/docs/man3.0/man7/crypto.html#LIBRARY-CONVENTIONS for the `get_0` conventions Differential Revision: D40942193 fbshipit-source-id: b9a868aec3d332e9de323cb801af52e2692d4686
|
This pull request was exported from Phabricator. Differential Revision: D40942193 |
|
Hi @Atry! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary:
In OpenSSL 3,
EVP_PKEY_get0_*functions now returnconstpointers, breaking existing usage depending on mutable pointers returned by OpenSSL 1.x. This diff fix the errorsautotype for return type ofEVP_PKEY_get0_*functions instead of mutable pointer types.EVP_PKEY_get0_RSAare replaced withEVP_PKEY_get1_RSAin order to get a mutable pointer with the ownership.See https://www.openssl.org/docs/man3.0/man7/crypto.html#LIBRARY-CONVENTIONS for the
get_0conventionsDifferential Revision: D40942193