This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Implementation of the selector highlight for the warnings #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pestevez
reviewed
Mar 24, 2021
pestevez
reviewed
Mar 24, 2021
pestevez
reviewed
Mar 24, 2021
pestevez
reviewed
Mar 24, 2021
pestevez
reviewed
Mar 24, 2021
There was a problem hiding this comment.
Looking great @nataliemt! I left a few comments, but feel free to push back on any of them if you feel strongly about them.
nataliemt
force-pushed
the
feature/warning-selector
branch
from
84db176 to
a023879
Compare
This was referenced Apr 12, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning tab display a list of warnings.
When clicking in one of the items, the element will be highlighted in the page to facilitate the identification of the warning is related to.
The highlight will be removed when the warning is clicked again, every time preview loads again or if the focus is set in one of the rules fields.
Required: facebookarchive/facebook-instant-articles-sdk-php#369