Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Implementation of methods to retrieve the warning selectors #369

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

nataliemt
Copy link
Contributor

This PR implements methods to retrieve the warning selectors that support the IA Build warning highlight functionality.

@pestevez
Copy link
Contributor

Hi @nataliemt, can you please add some tests for the new functionality? Thanks!

@nataliemt nataliemt force-pushed the feature/warning_selector branch from 569c95e to 328ace2 Compare March 24, 2021 13:24
Copy link
Contributor

@pestevez pestevez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This will be very useful for the Instant Articles Builder, thanks!

@pestevez pestevez merged commit 2ec0b25 into master Mar 24, 2021
@pestevez pestevez deleted the feature/warning_selector branch March 24, 2021 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants