Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FUNCTION_NAME_RESERVED_PATTERN stateless #4466

Merged
merged 2 commits into from
Sep 12, 2017

Conversation

thymikee
Copy link
Collaborator

Summary
As per discussion here.
This also fixes eslint by disabling flowtype/require-valid-file-annotation for *.md files

Test plan
Added a test for multiple reserved words

@@ -22,6 +22,7 @@ module.exports = {
files: ['*.md'],
rules: {
'consistent-return': 0,
'flowtype/require-valid-file-annotation': 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@19b5cce). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4466   +/-   ##
=========================================
  Coverage          ?   56.86%           
=========================================
  Files             ?      186           
  Lines             ?     6299           
  Branches          ?        3           
=========================================
  Hits              ?     3582           
  Misses            ?     2716           
  Partials          ?        1
Impacted Files Coverage Δ
packages/jest-mock/src/index.js 84.79% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b5cce...84ce409. Read the comment docs.

@cpojer cpojer merged commit 72af99d into jestjs:master Sep 12, 2017
tabrindle pushed a commit to tabrindle/jest that referenced this pull request Oct 2, 2017
* Make FUNCTION_NAME_RESERVED_PATTERN stateless

* Ignore valid flow annotations in *.md files
@thymikee thymikee deleted the fix/mock-pattern branch March 16, 2019 10:56
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants