Make FUNCTION_NAME_RESERVED_PATTERN stateless #4466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpojer
reviewed
Sep 12, 2017
| @@ -22,6 +22,7 @@ module.exports = { | |||
| files: ['*.md'], | |||
| rules: { | |||
| 'consistent-return': 0, | |||
| 'flowtype/require-valid-file-annotation': 0, | |||
Codecov Report
@@ Coverage Diff @@
## master #4466 +/- ##
=========================================
Coverage ? 56.86%
=========================================
Files ? 186
Lines ? 6299
Branches ? 3
=========================================
Hits ? 3582
Misses ? 2716
Partials ? 1
Continue to review full report at Codecov.
|
tabrindle
pushed a commit
to tabrindle/jest
that referenced
this pull request
Oct 2, 2017
* Make FUNCTION_NAME_RESERVED_PATTERN stateless * Ignore valid flow annotations in *.md files
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per discussion here.
This also fixes eslint by disabling
flowtype/require-valid-file-annotationfor*.mdfilesTest plan
Added a test for multiple reserved words