pretty-format: Omit non-enumerable symbol properties #7448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickhanlonii
approved these changes
Dec 2, 2018
CHANGELOG.md
Outdated
| @@ -77,6 +77,7 @@ | |||
| - `[jest-haste-map]` Remove legacy condition for duplicate module detection ([#7333](https://github.com/facebook/jest/pull/7333)) | |||
| - `[jest-haste-map]` Fix `require` detection with trailing commas and ignore `import typeof` modules ([#7385](https://github.com/facebook/jest/pull/7385)) | |||
| - `[jest-cli]` Fix to set prettierPath via config file ([#7412](https://github.com/facebook/jest/pull/7412)) | |||
| - `[pretty-format]` [**BREAKING**] Omit non-enumerable symbol properties ([#7448](https://github.com/facebook/jest/pull/7448)) | |||
There was a problem hiding this comment.
Can you move this to the top of this section with the other breaking changes?
|
@pedrottimark should we add a test for the snapshot matcher? |
Codecov Report
@@ Coverage Diff @@
## master #7448 +/- ##
=========================================
+ Coverage 66.8% 66.8% +<.01%
=========================================
Files 242 242
Lines 9374 9375 +1
Branches 6 5 -1
=========================================
+ Hits 6262 6263 +1
Misses 3110 3110
Partials 2 2
Continue to review full report at Codecov.
|
|
It looks like snapshot tests are not related to content. So integration test would be new e2e test. For now in a local project:
|
|
Off topic of this PR, can y’all explain why existing code filters out symbols from array of keys? const isSymbol = key =>
// $FlowFixMe string literal `symbol`. This value is not a valid `typeof` return value
typeof key === 'symbol' || toString.call(key) === '[object Symbol]';
let keys = Object.keys(val).sort();
if (symbols.length) {
keys = keys.filter(key => !isSymbol(key)).concat(symbols);
} |
|
Ah that's good enough for me! |
|
And no @pedrottimark I couldn't tell ya, did you blame it? |
thymikee
reviewed
Dec 3, 2018
| const symbols = getSymbols(val); | ||
| const symbols = getSymbols(val).filter( | ||
| //$FlowFixMe because property enumerable is missing in undefined | ||
| symbol => Object.getOwnPropertyDescriptor(val, symbol).enumerable, |
There was a problem hiding this comment.
I think this should this be a part of getSymbols, since it's only used in one place
thymikee
added a commit
to spion/jest
that referenced
this pull request
Dec 18, 2018
* master: (24 commits) Add `jest.isolateModules` for scoped module initialization (jestjs#6701) Migrate to Babel 7 (jestjs#7016) docs: changed "Great Scott!" link (jestjs#7524) Use reduce instead of filter+map in dependency_resolver (jestjs#7522) Update Configuration.md (jestjs#7455) Support dashed args (jestjs#7497) Allow % based configuration of max workers (jestjs#7494) chore: Standardize filenames: jest-runner pkg (jestjs#7464) allow `bail` setting to control when to bail out of a failing test run (jestjs#7335) Add issue template labels (jestjs#7470) chore: standardize filenames in e2e/babel-plugin-jest-hoist (jestjs#7467) Add node worker-thread support to jest-worker (jestjs#7408) Add `testPathIgnorePatterns` to CLI documentation (jestjs#7440) pretty-format: Omit non-enumerable symbol properties (jestjs#7448) Add Jest Architecture overview to docs. (jestjs#7449) chore: run appveyor tests on node 10 chore: fix failures e2e test for node 8 (jestjs#7446) chore: update docusaurus to v1.6.0 (jestjs#7445) Enhancement/expect-to-be-close-to-with-infinity (jestjs#7444) Update CHANGELOG formatting (jestjs#7429) ...
willsmythe
pushed a commit
to willsmythe/jest
that referenced
this pull request
Dec 20, 2018
* pretty-format: Omit non-enumerable symbol properties * Update CHANGELOG.md * Correct CHANGELOG.md * Move change line to other breaking under fixes
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
* pretty-format: Omit non-enumerable symbol properties * Update CHANGELOG.md * Correct CHANGELOG.md * Move change line to other breaking under fixes
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7443
Breaking change for upcoming major upgrade to Jest 24
cc @austinalameda @mweststrate
Goals:
toEqualmatcher.Test plan
Added 2 test cases: