Standardize File Name #7467
Standardize File Name #7467
Conversation
e2e/babel-plugin-jest-hoist/.babelrc
Outdated
| } | ||
| ], | ||
| "retainLines": true | ||
| } |
There was a problem hiding this comment.
In the issue I was having here: #7466. i was able to resolve it by removing the file. But I accidentally added this to the last commit it wasn't supposed to be pushed. I meant to ask about adding this separately since it seemed to have resolved the issue for me.
There was a problem hiding this comment.
In the issue I was having here: #7466. i was able to resolve it by removing the file
I don't experience this under macOS. Probably something Windows related. But generally it should work, maybe you didn't run yarn inside this directory?
Anyway, please add extra newline back :D
There was a problem hiding this comment.
I'm a bit confused as to where to put the newline, I copied the contents back from the original file over to this file from github. 😕
There was a problem hiding this comment.
Scratch that! I found it. :)
| @@ -123,7 +123,7 @@ describe('babel-plugin-jest-hoist', () => { | |||
| }); | |||
|
|
|||
| it('requires modules that also call jest.mock', () => { | |||
| require('../mock-file'); | |||
| require('../mock_file'); | |||
There was a problem hiding this comment.
why underscore? this should be mockFile
Codecov Report
@@ Coverage Diff @@
## master #7467 +/- ##
======================================
Coverage 66.8% 66.8%
======================================
Files 242 242
Lines 9375 9375
Branches 5 6 +1
======================================
Hits 6263 6263
Misses 3110 3110
Partials 2 2
Continue to review full report at Codecov.
|
Co-Authored-By: GGonryun <12995427+GGonryun@users.noreply.github.com>
* master: (24 commits) Add `jest.isolateModules` for scoped module initialization (jestjs#6701) Migrate to Babel 7 (jestjs#7016) docs: changed "Great Scott!" link (jestjs#7524) Use reduce instead of filter+map in dependency_resolver (jestjs#7522) Update Configuration.md (jestjs#7455) Support dashed args (jestjs#7497) Allow % based configuration of max workers (jestjs#7494) chore: Standardize filenames: jest-runner pkg (jestjs#7464) allow `bail` setting to control when to bail out of a failing test run (jestjs#7335) Add issue template labels (jestjs#7470) chore: standardize filenames in e2e/babel-plugin-jest-hoist (jestjs#7467) Add node worker-thread support to jest-worker (jestjs#7408) Add `testPathIgnorePatterns` to CLI documentation (jestjs#7440) pretty-format: Omit non-enumerable symbol properties (jestjs#7448) Add Jest Architecture overview to docs. (jestjs#7449) chore: run appveyor tests on node 10 chore: fix failures e2e test for node 8 (jestjs#7446) chore: update docusaurus to v1.6.0 (jestjs#7445) Enhancement/expect-to-be-close-to-with-infinity (jestjs#7444) Update CHANGELOG formatting (jestjs#7429) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This Pull Request helps standardizes file names in
./e2e/babel-plug-in-jest-hostunder Facebook naming conventions as outlined in issue #4969 & below:Test plan
No new tests were added. I used
..\..\packages\jest-cli\bin\jest.jswhile in the folder.\e2e\babel-plug-in-jest-hoistto verify that all tests passed.