-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit "only" mode unless there is tests with "only" mode already #7888
Conversation
# Conflicts: # CHANGELOG.md
It is little verbose solution. Welcome to other solutions |
Codecov Report
@@ Coverage Diff @@
## master #7888 +/- ##
==========================================
- Coverage 58.15% 58.08% -0.08%
==========================================
Files 173 173
Lines 6424 6427 +3
Branches 5 5
==========================================
- Hits 3736 3733 -3
- Misses 2686 2692 +6
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good!
Left a comment about the integration test, beyond that this lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this! Left some comments :)
Co-Authored-By: doniyor2109 <doniyor2109@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #7837
Test plan
yarn test