Update jest-leak-detector package to be compatible with the new Node version

[lh0x00]

At #8397, we know weak package doesn't work in Node version 12 and we use weak-napi package instead of weak in new version. weak-napi have interface like weak package but it still have some differences suck as:

GC callbacks are invoked at a suitable time (after the actual GC run has finished). This is nice because it means your process won’t potentially crash.

The consequence of this is that the isLeaking function in jest-leak-detector package return value must be converted into a promise to wait a bit time.

Fixes #8397

[SimenB]

We should remove the conditional require now, which'll necessitate typings.

Since we're changing the signature, that also means this is a breaking change... I see CI fails for node 6, but since it's breaking we'll just drop node 6 anyways

[lh0x00]

@SimenB @jeysal DT was released type for weak-napi package at @types/weak-napi and I added it. PR was updated.

[SimenB]

Hmm, something seems to be off with CI - Circle runs on your account instead of Jest's. Not sure how that happened

[lh0x00]

how I fix it? :<
I turned off CircleCI in my repo, please trigger run the build again.

[jeysal]

Noticed Circle doing the same for #8689, perhaps it only worked there because I have the necessary permissions. Maybe it works if you remove your fork from the list of projects that Circle builds.

[lh0x00]

@jeysal I have removed it from list in my CircleCI. Please trigger run build agian!

[jeysal]

I don't know if we can rerun if there's no build for this PR in the history. Can you try to

git commit --amend --no-edit && git push -f

[lh0x00]

I did it and waiting to CircleCI re-run

[SimenB]

That worked 👌

[SimenB]

Either leak detection has improved or it's now wrong... See the node 10 failure (where we run --leak-detector on ourselves). I restarted it for now in case it's transient

[lh0x00]

node-10 is working well but I see an error in test-jest-circus and I don't know why CI throw this error!?

[jeysal]

circus is unrelated, happens on master too

[lh0x00]

this PR will be waiting to test on node-12 before, right?

[SimenB]

Yeah, we'll merge this when we start landing breaking changes.

[SimenB]

Thanks!

[lh0x00]

many thanks for reviewed! ^^

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.