Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test on node 12 #8411

Merged
merged 2 commits into from
Aug 19, 2019
Merged

chore: test on node 12 #8411

merged 2 commits into from
Aug 19, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 2, 2019

Summary

Node 12 is out, and it's shiny!

Test plan

Probably gonna fail due to #8397

.circleci/config.yml Outdated Show resolved Hide resolved
@SimenB SimenB mentioned this pull request May 11, 2019
4 tasks
@SimenB SimenB changed the base branch from master to next August 19, 2019 10:27
@SimenB SimenB force-pushed the node-12 branch 2 times, most recently from fc4c665 to a77cafc Compare August 19, 2019 10:39
@SimenB
Copy link
Member Author

SimenB commented Aug 19, 2019

Actual test errors now 🙂 Two stack trace changes which I'll deal with, and a weird error in precision...

image

@pedrottimark any idea on why this fails for node 12?

@pedrottimark
Copy link
Contributor

@SimenB Although I didn’t find the reason why, see #8389 which we held back to avoid merge conflict with #8382 but since that also has conflicts, do you want me to get the fix ready to merge?

@SimenB
Copy link
Member Author

SimenB commented Aug 19, 2019

Aha, thanks! Let's land #8389 on master - that's not a breaking change. #8382 is breaking, so that has to wait a bit

@SimenB
Copy link
Member Author

SimenB commented Aug 19, 2019

image

🎉

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants