-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pretty-format to respect displayName on forwardRef. #9422
Conversation
Unlike React DevTools, Jest ignores a custom displayName set on forwardRef components. We should align serialization with DevTools, so change behavior.
Hi DiZy! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Changelog, and this should go in major release. |
Codecov Report
@@ Coverage Diff @@
## master #9422 +/- ##
==========================================
+ Coverage 64.8% 64.83% +0.02%
==========================================
Files 281 281
Lines 12000 12002 +2
Branches 2960 2961 +1
==========================================
+ Hits 7777 7781 +4
Misses 3591 3591
+ Partials 632 630 -2
Continue to review full report at Codecov.
|
Sorta related: #7460 - do you think that's needed? |
@SimenB No, that's not using |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Unlike React DevTools, Jest ignores a custom displayName set on forwardRef components. We should align serialization with DevTools, so change the behavior.
Test plan
Created a new unit test to cover the changes.
CC @scotthovestadt @bvaughn