Fix for pretty-format and react elements

[rickhanlonii]

Summary

This PR fixes an issue with the pretty-format react plugin where it was only checking the $$typeof symbol for object element types. I found that function element types are possible with the $$typeof checks, so I moved those checks to before the typeof type === function check

The practical change is that in some scenarios, instead of printing

<Component />

We will now print

<ForwardRef(Foo) />

Test plan

I actually can't figure out how to write a test for this issue in our repo, but I did apply the change manually in https://github.com/rajivshah3/rn-broken-snapshot/tree/broken-example, where I discovered the issue, to confirm the fix

I suspect it's related to some combination of jest, react, react-native, and react-test-renderer

[thymikee]

This is also very dependent on RN version – <Component /> usually signs lack of proper displayName provided for ForwardedRefs. Just make sure with React team that we can safely check functions same as objects.

[SimenB]

Can we use https://www.npmjs.com/package/react-is?

[SimenB]

#7895

[SimenB]

Ergh, the fix this PR attempt to provide isn't solved... Not sure why I closed this.

We now use react-is at least, so it should be cleaner. This needs a test, though 🙂

[SimenB]

@rickhanlonii any plans for this?

[rickhanlonii]

Probably will not be able to look at this until next year

[SimenB]

@rickhanlonii it's a new year! 😀

[rickhanlonii]

Wow, @SimenB I literally just started fixing this because it's a bigger issue on the React main branch, thanks for bumping and reminding me that I already fixed it. I'll get this in.

[SimenB]

Perfect! 😀 We got #10120 from a Ghost as well, should it be closed by this?

[rickhanlonii]

Actually I'm going to close this, the bug here was in the way we were doing mocks in React Native and was fixed by facebook/react-native@4b935ae

[SimenB]

👍

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.