Newlines stripped from processed files

[pieterv]

new lines seem to be removed even if i dont change a file, for now i am having to do:

return root.toSource({quote: 'single', trailingComma: true}) + '\n';

Maybe this is an issue with recast?

[pieterv]

Hmm maybe this fixes it, benjamn/recast#199

[fkling]

Mmh, have to look at the recast thing, but also have a look at #27.

[cpojer]

@fkling this is exactly what I mentioned yesterday. Everyone gets tripped up by this. Let's just merge #27 with the auto-detection? That should cover this really nicely without a "breaking" change.

[fkling]

@cpojer: I know, I was just wondering what recast did about this since it was mentioned there as well.

[fkling]

So, the issue seems to be with using Babel as parser. If esprima is used, trailing and leading whitespace is preserved. I'd suggest we first look into if we can fix this in recast before making changes to jscodeshift.

edit: nvm, it works also when I use babel-core as parser... now I'm confused...

[fkling]

OK, I know what the issue is. recast.parse(...) returns a File AST node which contains the location information about the leading and trailing white spaces, but since we are throwing that object away and only use program in https://github.com/facebook/jscodeshift/blob/master/src/core.js#L74, we are loosing that information.

Maybe everything will just work if we use the File object instead.

[pieterv]

Awesome! Thanks @fkling

[fkling]

Release in v0.3.3 btw.

[nebirhos]

It looks like this is an issue again in v0.4.0.

Edit: Tested the same script with v0.3.32, newlines are preserved as expected.

[ibrahima]

Aha, ran into this issue as well. I can confirm that downgrading to v0.3.32 fixes the issue.