Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unhandled Promise rejection when called with a non-existent path #334

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

threepointone
Copy link

@threepointone threepointone commented Jul 18, 2019

When jscodeshift is called with a path that doesn't exist, concatAll() gets called with undefined, which isn't an iterable, and throws an error. This PR fixes the promise being resolved by matching it with the ignore case.

When jscodeshift is called with a path that doesn't exist, `concatAll()` gets called with `undefined`, which isn't an interable, and throws an error. This PR fixes the promise being resolved by matching it with the ignore case.
Copy link

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running up against this right now. This seems like a good fix!

@AndersDJohnson
Copy link

Yes! I would love for this fix to be merged in and released, and/or the PR I raised (#339) to address the same symptom. Thanks!

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants