Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GitHub Action to run test #493

Merged
merged 4 commits into from
Mar 26, 2022
Merged

feat: add GitHub Action to run test #493

merged 4 commits into from
Mar 26, 2022

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Mar 25, 2022

@trivikr
Copy link
Contributor Author

trivikr commented Mar 25, 2022

@Daniel15 Can you enable GitHub Actions on jscodeshift repo so that this CI can run?

@Daniel15
Copy link
Member

From reading our internal docs, it looks like GitHub Actions should be enabled by default, and I just need to merge these changes. Are the actions running on your fork (so we can see that they're working)?

@trivikr
Copy link
Contributor Author

trivikr commented Mar 25, 2022

Are the actions running on your fork (so we can see that they're working)?

Yes. I verified in https://github.com/trivikr/jscodeshift/pull/1 that GitHub Actions are running yarn test

@Daniel15
Copy link
Member

Daniel15 commented Mar 25, 2022

Awesome. Thanks! One small inline comment and then I'll merge it.

.github/workflows/test.yml Outdated Show resolved Hide resolved
@trivikr trivikr requested a review from Daniel15 March 25, 2022 22:23
@Daniel15 Daniel15 merged commit 4a3db92 into facebook:main Mar 26, 2022
@trivikr trivikr deleted the github-actions branch March 26, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants