Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix symlink problems #92

Merged
merged 2 commits into from
Mar 9, 2016
Merged

Conversation

avikchaudhuri
Copy link
Contributor

Re-implement the function dir.files that walks directories to collect files.

The main change is that when stat problems are encountered (e.g., due to symlink issues), we log an error but continue on, instead of refusing to any work.

@zertosh
Copy link
Member

zertosh commented Mar 6, 2016

I've had similar problems before, but I ended up going with find ... | xargs jscodeshift since that gives me way more control (e.g. exclude node_modules). Just thinking out loud, I wonder if jscodeshift should be in the business of directory walking at all?

@cpojer
Copy link
Contributor

cpojer commented Mar 6, 2016

@zertosh it was added mainly as a convenience. I think jscodeshift should provide a reasonable default.

@zertosh
Copy link
Member

zertosh commented Mar 6, 2016

Fair enough!

fkling added a commit that referenced this pull request Mar 9, 2016
@fkling fkling merged commit 042f70b into facebook:master Mar 9, 2016
@fkling
Copy link
Contributor

fkling commented Mar 9, 2016

One issue with find and xargs is that if you have too many files, xargs will spawn multiple jscodeshift processes. But I guess we can fix that too by letting jscodeshift read from stdin.

euphocat pushed a commit to euphocat/jscodeshift that referenced this pull request Oct 22, 2017
* Add first pass of supporting es6 imports in react-to-react-dom

* Add tests for es6 imports in react-to-react-dom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants