-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle Lexical DevTools with Vite #2415
Bundle Lexical DevTools with Vite #2415
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@noi5e You shouldn't need any kind of special access to resolve the merge conflict. Update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set up looks fine, but how com we've got rid of TypeScript? That should work out of the box for Vite. See the react-ts
example here: https://vitejs.dev/guide/#trying-vite-online
@thegreatercurve Thanks for the assist, and helping this to pass the CI! Looks like the last few reviews you mentioned were covered by your commit as well. This might be ready to merge, although I do have a slight question mark about deleting |
@noi5e your folder is included in the |
This does everything that PR #2388 did, it just creates a browser extension scaffold with Vite instead of Create React App/webpack.
Lots of file/folder structural changes, but not any functional difference for the user. Even the installation instructions in
README.md
are the same.I'm still figuring out how to do the Vite config. Right now the assets are split into two folders:
src
- React componentspublic
- I made this folder as a workaround, in order to get Vite to includemanifest.json
(and everything it references) within thebuild
. Following Vite docs.It's pretty crucial that the browser extension
build
includes amanifest.json
. It seems like Vite doesn't do this out of the box.An outside repo makes a custom Vite plugin that will generate a
manifest.json
, and it looks relatively easy to replicate. I haven't done this yet, will save it for another PR.Developer Tools Web Extension Planning Issue: #2127