Inject DevTools Script in Browser Extension #2778
Conversation
noi5e
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
| interface DocumentEventMap { | ||
| editorStateUpdate: CustomEvent; | ||
| } | ||
| } |
There was a problem hiding this comment.
For the highlight CustomEvent. I'm unsure if a declare global is what I'm supposed to be doing here. @thegreatercurve
There was a problem hiding this comment.
You can do, it will just get referenced in this module scope either way.
| const data = {lexicalKey: message.lexicalKey}; | ||
| const detail = IS_FIREFOX | ||
| ? // eslint-disable-next-line no-undef | ||
| cloneInto(data, document.defaultView) // see https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Sharing_objects_with_page_scripts#cloneinto |
There was a problem hiding this comment.
This is the only TS error I couldn't find a way to handle. This is a Firefox-only browser extension API.
There's a definition written in this package, should I just copy it?
There was a problem hiding this comment.
Okay, I just went ahead and wrote a cloneInto type. After all, it's just deep cloning the same object.
But now I get this error:
Where to go from here? Declare the definition on the window?
There was a problem hiding this comment.
Here's the current type definition from types.ts:
export type cloneInto = (
arg: {data: {lexicalKey: string}},
arg2: WindowProxy,
) => {data: {lexicalKey: string}};
There was a problem hiding this comment.
Something like this within content.ts?
| interface DocumentEventMap { | ||
| editorStateUpdate: CustomEvent; | ||
| } | ||
| } |
There was a problem hiding this comment.
You can do, it will just get referenced in this module scope either way.
noi5e
force-pushed
the
inject-devtools-script
branch
from
5ce53b2 to
81e0e1a
Compare
|
@thegreatercurve My current fix for cloneInto being undefined is a little weird, you might want to take a look. I ended up dropping a Otherwise this is merge ready! |
@noi5e This seems fine to me. You're not polluting any global name space with this, and tbh, I'd probably just case it to |
* move devtools code to injected script * correct typescript errors * write cloneInto type * add injected script to web_accessible_resources * fix highlighting bug * wrapper function for cloneInto
This moves all of the code that was previously running as an inline string in
devtools.inspectedWindow.eval()like so:And moves it to a new
inject.tsfile:Developer Tools Web Extension Planning Issue: #2127