Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add size limit report #3600

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Add size limit report #3600

merged 1 commit into from
Dec 22, 2022

Conversation

fantactuka
Copy link
Contributor

@fantactuka fantactuka commented Dec 20, 2022 •
edited
Loading

Adds PR size report for lexical core, plain and rich text packages

@vercel
Copy link

vercel bot commented Dec 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 20, 2022 at 3:18PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 20, 2022 at 3:18PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2022
@fantactuka
Copy link
Contributor Author

fantactuka commented Dec 20, 2022 •
edited
Loading

Looking into failed "size" GH action, and it seems like it tries to switch to main branch and run size limit as well which fails as we don't have it in main yet. So we probably will need to merge this PR to get proper size report

acywatson
acywatson approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@acywatson acywatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of the dangerJS dependency? I think it was attempting to serve the same purpose.

@fantactuka
Copy link
Contributor Author

dangerJS

Don't see it anywhere

@fantactuka fantactuka merged commit 8da9bb2 into main Dec 22, 2022
@fantactuka fantactuka deleted the size-limit branch December 22, 2022 19:02
@trueadm trueadm mentioned this pull request Dec 23, 2022
Merged
@etrepum etrepum mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acywatson acywatson acywatson approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fantactuka @acywatson @facebook-github-bot