You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tbh, I was just going to do it as a minor release. The hooks have been marked as deprecated since we made the library public, so not sure it necessarily constitutes a breaking change
Tbh, I was just going to do it as a minor release. The hooks have been marked as deprecated since we made the library public, so not sure it necessarily constitutes a breaking change
I understand your perspective here, but it's definitely a breaking change. I doubt it will break many consumers, practically, but removing any public API can cause builds to suddenly fail if they're pulling in the latest patch version (which is common).
Tbh, I was just going to do it as a minor release. The hooks have been marked as deprecated since we made the library public, so not sure it necessarily constitutes a breaking change
I understand your perspective here, but it's definitely a breaking change. I doubt it will break many consumers, practically, but removing any public API can cause builds to suddenly fail if they're pulling in the latest patch version (which is common).
I think it's fine. I've done it with the other modules and it's not an unexpected breaking change if the module has forever been marked as deprecated.
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thegreatercurve
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson and
tylerjbainbridge
as code owners
facebook-github-bot
added
the
CLA Signed
No description provided.