Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve serialization types for element node children #3990

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Improve serialization types for element node children #3990

merged 1 commit into from
Feb 28, 2023

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Feb 27, 2023 •
edited
Loading

More typesafe alternative to solution proposed in #3989

@vercel
Copy link

vercel bot commented Feb 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 0:48AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 0:48AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2023
@thegreatercurve thegreatercurve changed the title y Improve serialization types for element node children Feb 27, 2023
@thegreatercurve thegreatercurve marked this pull request as ready for review February 27, 2023 12:47
@thegreatercurve thegreatercurve mentioned this pull request Feb 27, 2023
Closed
@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.11 KB (0%) 523 ms (0%) 263 ms (+15.69% 🔺) 785 ms
packages/lexical-rich-text/dist/LexicalRichText.js 36.88 KB (0%) 738 ms (0%) 267 ms (-31.41% 🔽) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 36.85 KB (0%) 737 ms (0%) 331 ms (+21.18% 🔺) 1.1 s

@acywatson acywatson merged commit 9103457 into main Feb 28, 2023
@acywatson acywatson deleted the bug/serialization-types branch February 28, 2023 03:30
@acywatson acywatson mentioned this pull request Mar 8, 2023
Merged
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acywatson acywatson acywatson approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thegreatercurve @acywatson @facebook-github-bot