Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.9] Remove experimental flag for copyToClipboard #4037

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[0.9] Remove experimental flag for copyToClipboard #4037

merged 1 commit into from
Mar 8, 2023

Conversation

thegreatercurve
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Mar 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 9:42AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 9:42AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2023
@thegreatercurve thegreatercurve changed the title Remove experimental flag for copyToClipboard [0.9] Remove experimental flag for copyToClipboard Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.09 KB (0%) 522 ms (0%) 288 ms (+27.04% 🔺) 810 ms
packages/lexical-rich-text/dist/LexicalRichText.js 36.87 KB (-0.04% 🔽) 738 ms (-0.04% 🔽) 425 ms (-0.15% 🔽) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 36.84 KB (-0.04% 🔽) 737 ms (-0.04% 🔽) 455 ms (+10.08% 🔺) 1.2 s

@thegreatercurve
Copy link
Contributor Author

@zurfyx Can you sense check that this flag is okay to be removed? The function has been in use for around 6 month without any reported bugs.

@acywatson acywatson merged commit d126f97 into main Mar 8, 2023
@acywatson acywatson mentioned this pull request Mar 8, 2023
Merged
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Merged
@fantactuka fantactuka deleted the feat/remove-experimental-flag-copy-to-clipboard branch July 6, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thegreatercurve @zurfyx @facebook-github-bot @acywatson