feat(@lexical/devtools): Added basic extension scaffolding #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
StyleT
force-pushed
the
feature/devtools_extension
branch
from
2502b3d to
b0105b1
Compare
StyleT
force-pushed
the
feature/devtools_extension
branch
from
11f5e69 to
4aa3be8
Compare
StyleT
force-pushed
the
feature/devtools_extension
branch
from
4aa3be8 to
bc44908
Compare
StyleT
force-pushed
the
feature/devtools_extension
branch
from
bc44908 to
7b51f73
Compare
StyleT
force-pushed
the
feature/devtools_extension
branch
from
7b51f73 to
c8a3f4f
Compare
StyleT
force-pushed
the
feature/devtools_extension
branch
from
c8a3f4f to
081f600
Compare
StyleT
force-pushed
the
feature/devtools_extension
branch
from
081f600 to
1221bf7
Compare
StyleT
force-pushed
the
feature/devtools_extension
branch
from
1221bf7 to
e803b2e
Compare
acywatson
reviewed
Apr 1, 2024
| // $ openssl rsa -in key.pem -pubout -outform DER | openssl base64 -A # this key below (strip % at the end) | ||
| // $ openssl rsa -in key.pem -pubout -outform DER | shasum -a 256 | head -c32 | tr 0-9a-f a-p # extension ID | ||
| // @ts-expect-error https://github.com/wxt-dev/wxt/issues/521#issuecomment-1978147707 | ||
| manifestConf.key = |
There was a problem hiding this comment.
Nowhere as it's not needed for dev purposes. We'll use GitHub Secrets for publishing
etrepum
reviewed
Apr 2, 2024
| // TODO: refresh editors present of the page | ||
| const lexicalNodes = Array.from( | ||
| document.querySelectorAll('div[data-lexical-editor]').values(), | ||
| ) as LexicalHTMLElement[]; |
There was a problem hiding this comment.
Might be worth a filter here (maybe with a type guard that validates everything at runtime instead of casting) since a SSR-rendered editor (and possibly other scenarios) could leave a residual data prop but no attached LexicalEditor?
StyleT
force-pushed
the
feature/devtools_extension
branch
from
01d2deb to
ef96981
Compare
Includes: - Extension with TS/React support - HMR for extension panels and fast reload for other configs - Dev mode with browser auto-start with dedicated profile
…op/start within store
…l Panel Lexical state shown in devtools panel
…efactoring feat: webext-zustand broken onto several files
StyleT
force-pushed
the
feature/devtools_extension
branch
from
ecee240 to
b32d824
Compare
acywatson
approved these changes
Apr 2, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaffolding Includes:
Out of scope:
Demo in Chrome:
Screen.Recording.2024-03-26.at.7.57.02.PM.1.mov
Demo in Firefox:
Screen.Recording.2024-03-26.at.8.15.14.PM.mov
DevX demo:
Screen.Recording.2024-03-26.at.9.06.13.PM.mov