[lexical] Bug Fix: Fix getNodes over-selection #7006
Merged
+109
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
etrepum
changed the title
etrepum
commented
Dec 31, 2024
| @@ -1129,7 +1148,7 @@ export class RangeSelection implements BaseSelection { | |||
| lastPoint.offset = lastNode.getTextContentSize(); | |||
| } | |||
|
|
|||
| selectedNodes.forEach((node) => { | |||
| for (const node of selectedNodes) { | |||
There was a problem hiding this comment.
Loops are generally more performant and provide a better debugging experience than Array.prototype.forEach
| const deleteCount = nodes.findIndex( | ||
| (node) => !node.is(firstNode) && !node.isBefore(firstNode), | ||
| ); | ||
| nodes.splice(0, deleteCount); |
There was a problem hiding this comment.
note that this doesn't need any sort of bounds checking because a negative deleteCount is equivalent to 0.
ivailop7
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ElementNode.getDescendantByIndexhas error-prone semantics where it will return the last descendant when the index overflows. There was already a workaround for over-selection on the lastNode side forgetNodes()and this adds a similar workaround for the firstNode side.The most common side-effect of this (literal) edge case is that too many nodes would be deleted by
removeText, particularly when an element ends with aDecoratorNodeand the point is at the offset after it.Closes #6974
Closes #6851
Closes #6842
Test plan
See new regression test, plus all existing suites.